Return error when the template's single interpolation results in null value #36658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SarahFrench
previously approved these changes
Mar 10, 2025
| @@ -0,0 +1,5 @@ | |||
| kind: BUG FIXES | |||
| body: Return error when the template's single interpolation results in null value | |||
There was a problem hiding this comment.
Could you please update the change file to mention the templatestring function?
dsa0x
commented
Mar 10, 2025
SarahFrench
approved these changes
Mar 10, 2025
dsa0x
added
the
1.11-backport
Changelog WarningCurrently this PR would target a v1.11 release. Please add a changelog entry for in the .changes/v1.11 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label. |
2 tasks
|
Heads up, the changelog for this change has ended up in the wrong folder and wrong branch. Since it was backported to 1.11, there should only be a changelog file on the v1.11 branch in the .changes/1.11 directory. None on main |
|
Thanks @dbanck. I'll move appropriately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36652
When a string interpolation contains only one expression sequence, HCL optimizes by wrapping and directly delegating evaluation to that expression. The
templatestringfunction tries to refine the expression value as non-null, and if null, this refinement leads to a panic. For compatibility reasons, HCL has to continue to support this unwrapping logic (See attempted PR), thus we will simply return an error intemplatestringwhen the single evaluated expression is nullTarget Release
1.12.x
CHANGELOG entry