Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for failed language server install #580

Merged
merged 2 commits into from
Mar 10, 2021

Conversation

aeschright
Copy link
Contributor

Fixes #578

Screen Shot 2021-03-09 at 2 50 10 PM

@aeschright aeschright requested a review from a team March 9, 2021 22:52
@aeschright
Copy link
Contributor Author

That top error message isn't that helpful to users, so I made another change to catch and report it, letting the extension still be activated. Now all they'll see is this:
Screen Shot 2021-03-09 at 3 10 23 PM

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you 🚢

@aeschright aeschright merged commit 03a2690 into main Mar 10, 2021
@aeschright aeschright deleted the install-errors branch March 10, 2021 18:46
@ghost
Copy link

ghost commented Apr 9, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve installation error handling for common filesystem issues
2 participants