Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for language server updates every 24 hours #595

Merged
merged 4 commits into from
Mar 24, 2021
Merged

Check for language server updates every 24 hours #595

merged 4 commits into from
Mar 24, 2021

Conversation

aeschright
Copy link
Contributor

Fixes #588

@aeschright aeschright requested a review from a team March 22, 2021 19:21
appilon
appilon suggested changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor feedback, I may be mistaken on the caching thing, if so then overall looks good!

src/languageServerInstaller.ts Outdated
@@ -32,31 +36,45 @@ export class LanguageServerInstaller {
isInstalled = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just return true here early (needsInstall because isInstalled == false)

src/languageServerInstaller.ts Outdated
this.showChangelog(this.release.version);
}

_latestReleasePromise: Promise<Release>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we want to cache this result? It seemed like updates were checked for on a schedule now, so I think we don't want to cache the response, that way when a new release goes out, the logic will show a mismatch between what the user has installed and the new latest

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll remove it, I was thinking I would need it between checking whether there's an update and installing it, but I went in a different direction for that part.

@aeschright aeschright requested a review from appilon March 23, 2021 21:58
appilon
appilon approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@appilon appilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeschright aeschright merged commit ad91435 into main Mar 24, 2021
@aeschright aeschright deleted the ls-install-check branch March 24, 2021 18:05
@ghost
Copy link

ghost commented Apr 23, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appilon appilon appilon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for language server updates daily
2 participants
@aeschright @appilon