Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix terraform status bar #857

Merged
merged 3 commits into from
Nov 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import { config, getActiveTextEditor } from './vscodeUtils';

const brand = `HashiCorp Terraform`;
const outputChannel = vscode.window.createOutputChannel(brand);
const terraformStatus = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 0);
export let terraformStatus: vscode.StatusBarItem;

let reporter: TelemetryReporter;
let clientHandler: ClientHandler;
Expand All @@ -27,6 +27,7 @@ export interface TerraformExtension {

export async function activate(context: vscode.ExtensionContext): Promise<TerraformExtension> {
const manifest = context.extension.packageJSON;
terraformStatus = vscode.window.createStatusBarItem(vscode.StatusBarAlignment.Left, 0);
reporter = new TelemetryReporter(context.extension.id, manifest.version, manifest.appInsightsKey);
context.subscriptions.push(reporter);

Expand Down Expand Up @@ -157,8 +158,9 @@ export async function deactivate(): Promise<void> {
return clientHandler.stopClient();
}

async function updateTerraformStatusBar(documentUri: vscode.Uri): Promise<void> {
const initSupported = clientHandler.clientSupportsCommand('terraform-ls.terraform.init');
export async function updateTerraformStatusBar(documentUri: vscode.Uri): Promise<void> {
const client = clientHandler.getClient();
const initSupported = clientHandler.clientSupportsCommand(`${client.commandPrefix}.terraform-ls.terraform.init`);
if (initSupported) {
const client = clientHandler.getClient();
const moduleUri = Utils.dirname(documentUri);
Expand All @@ -175,6 +177,7 @@ async function updateTerraformStatusBar(documentUri: vscode.Uri): Promise<void>
terraformStatus.show();
} else {
terraformStatus.hide();
terraformStatus.text = '';
}
} catch (err) {
vscode.window.showErrorMessage(err);
Expand Down
29 changes: 29 additions & 0 deletions src/test/integration/statusBar.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import * as assert from 'assert';
import * as vscode from 'vscode';
import { expect } from 'chai';
import { terraformStatus, updateTerraformStatusBar } from '../../extension';
import { getDocUri } from '../helper';

suite('statusBar', () => {
teardown(async () => {
await vscode.commands.executeCommand('workbench.action.closeAllEditors');
});

test('should create a status bar item on activate', () => {
assert.notStrictEqual(terraformStatus, undefined);
});

test('should create a status bar with the root module label', async () => {
const documentUri = getDocUri('sample.tf');
await updateTerraformStatusBar(documentUri);

expect(terraformStatus.text).to.equal('$(refresh) testFixture');
});

test('should create an empty status bar inside a child module', async () => {
const documentUri = getDocUri('modules/sample.tf');
await updateTerraformStatusBar(documentUri);

expect(terraformStatus.text).to.equal('');
});
});