Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate terraform.languageServer.requiredVersion #903

Merged
merged 2 commits into from
Jan 13, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jan 12, 2022

This adds a deprecation message to the terraform.languageServer.requiredVersion setting.

This setting will be removed in a future release when this extension adopts platform specific extension publishing.

In a future release, the extension will bundle the terraform-ls binary inside the published VSIX. This eliminates the need to download the binary at runtime, but also means the user cannot change the terraform-ls version used. Since they cannot change the version, this setting will no longer be needed.

Users who wish to use a different version than the one shipped with the extension will use terraform.languageServer.pathToBinary instead and install the terraform-ls binary using one of the release artifacts or through a package manager.

More detailed documentation on this process will be added when platform specific extension support is added.

This adds a deprecation message to the `terraform.languageServer.requiredVersion` setting.

This setting will be removed in a future release when this extension adopts platform specific extension publishing.

In a future release, the extension will bundle the terraform-ls binary inside the published VSIX. This eliminates the need to download the binary at runtime, but also means the user cannot change the terraform-ls version used. Since they cannot change the version, this setting will no longer be needed.

Users who wish to use a different version than the one shipped with the extension will use `terraform.languageServer.pathToBinary` instead and install the terraform-ls binary using one of the release artifacts or through a package manager.

More detailed documentation on this process will be added when platform specific extension support is added.
@jpogran jpogran requested a review from a team January 12, 2022 20:13
@jpogran jpogran added the enhancement New feature or request label Jan 12, 2022
@jpogran jpogran self-assigned this Jan 12, 2022
@jpogran jpogran marked this pull request as ready for review January 12, 2022 20:14
Co-authored-by: Radek Simko <radek.simko@gmail.com>
@jpogran jpogran merged commit 3668713 into main Jan 13, 2022
@jpogran jpogran deleted the deprecate_ls_required_version branch January 13, 2022 12:09
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants