Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terraform TextMate Test Infrastructure #912

Merged
merged 4 commits into from
Feb 1, 2022
Merged

Terraform TextMate Test Infrastructure #912

merged 4 commits into from
Feb 1, 2022

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Jan 31, 2022

This commit:

  • Adds testing infrastructure using vscode-tmgrammar-test to test the Terraform tmGrammar file. A minimal example file is used to demonstrate basic testing. Additional tests will be added as grammar is modified or changed.
  • Add tmGrammar schema to project to enable VS Code to provide intellisense and minimal validation of the tmGrammar files, whether they are json or yaml.
  • Updates the DEVELOPMENT readme and adds documentation on how to edit and test the Terraform tmGrammar
  • Automatically tests the grammar on every pull request

@jpogran
Terraform TextMate Test Infrastructure
226239b 
This commit:

- Adds testing infrastructure using vscode-tmgrammar-test to test the Terraform tmGrammar file. A minimal example file is used to demonstrate basic testing. Additional tests will be added as grammar is modified or changed.
- Add tmGrammar schema to project to enable VS Code to provide intellisense and minimal validation of the tmGrammar files, whether they are json or yaml.
- Updates the DEVELOPMENT readme and adds documentation on how to edit and test the Terraform tmGrammar
- Automatically tests the grammar on every pull request
@jpogran jpogran self-assigned this Jan 31, 2022
@jpogran jpogran added ci Continuous integration/delivery related documentation Improvements or additions to documentation enhancement New feature or request labels Jan 31, 2022
@jpogran jpogran marked this pull request as ready for review January 31, 2022 17:04
dbanck
dbanck approved these changes Feb 1, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a minor suggestion - feel free to merge afterwards 🙂

@jpogran @dbanck
Update jest.config.js
d5190a8 
Co-authored-by: Daniel Banck <dbanck@users.noreply.github.com>
radeksimko
radeksimko approved these changes Feb 1, 2022
View reviewed changes
@jpogran @radeksimko
Apply suggestions from code review
d3c8e3e 
Co-authored-by: Radek Simko <radek.simko@gmail.com>
@jpogran jpogran merged commit 59987ae into main Feb 1, 2022
@jpogran jpogran deleted the test_syntax_grammar branch February 1, 2022 13:57
@jpogran jpogran mentioned this pull request Feb 1, 2022
Closed
@jpogran jpogran added this to the 2.20.0 milestone Feb 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

@radeksimko radeksimko radeksimko approved these changes

Assignees

@jpogran jpogran

Labels
ci Continuous integration/delivery related documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
2.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jpogran @dbanck @radeksimko