Move TextMate scope.terraform to source.terraform #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the TextMate scopeName from `scope.terraform` to `source.terraform` inside the Terraform TextMate Grammar file. The current scopeName for the Terraform TextMate grammar is `scope.terraform`: https://github.com/hashicorp/vscode-terraform/blob/59987ae480a970b5955c94260abfa41fccb8577e/syntaxes/terraform.tmGrammar.json#L2 According to the TextMate documentation, the scopename should follow this naming conventions: > scopeName — this should be a unique name for the grammar, following the convention of being a dot-separated name where each new (left-most) part specializes the name. Normally it would be a two-part name where the first is either text or source and the second is the name of the language or document type. This means we need to change the Terraform scope name to `source.terraform`. This should not affect any existing themes or current syntax as themes are targeted towards the most specific token scope, like `comment.line`.double-slash, and not the language scopeName. Themes would be affected if our scopes were named `comment.line.double-slash.terraform` and we were changing the terraform part, but we have not named our scopes that way so we are unaffected.
jpogran
force-pushed
the
change_scope_name
branch
from
61ee273 to
33606e6
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the TextMate scopeName from
scope.terraformtosource.terraforminside the Terraform TextMate Grammar file.The current scopeName for the Terraform TextMate grammar is
scope.terraform:vscode-terraform/syntaxes/terraform.tmGrammar.json
Line 2 in 59987ae
According to the TextMate documentation, the scopename should follow this naming conventions:
This means we need to change the Terraform scope name to
source.terraform.This should not affect any existing themes or current syntax as themes are targeted towards the most specific token scope, like
comment.line.double-slash, and not the language scopeName. Themes would be affected if our scopes were namedcomment.line.double-slash.terraformand we were changing the terraform part, but we have not named our scopes that way so we are unaffected.