Fix Issue 1004: effect order in filterAMissing #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of Applicative effects in filterAMissing was incorrect, causing the order of effects to differ from key order and be influenced by how the binary tree was balanced. The fix is to arrange that effects arising from the key and value at an internal node come after those in its left branch instead of before. (Regardless of this fix such effects come before those effects arising from the right branch.) This change also expands test coverage to detect a regression of this fix.
|
Since I lack permission to initiate a continuous integration workflow or assign a reviewer, would someone be so kind as to trigger those steps? |
|
Sorry I missed this. |
|
Thanks! |
|
Thanks for the CI and merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of Applicative effects in filterAMissing
was incorrect, causing the order of effects to
differ from key order and be influenced by how
the binary tree was balanced.
The fix is to arrange that effects arising from
the key and value at an internal node come after
those in its left branch instead of before.
(Regardless of this fix such effects come before
those effects arising from the right branch.)
This change also expands test coverage
to detect a regression of this fix.