Revert "Fix potential out of bounds access in msc_disk.c"

hathach · Jan 25, 2025 · 77e0839 · 77e0839
1 parent 597446f
commit 77e0839
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/examples/device/cdc_msc/src/msc_disk.c b/examples/device/cdc_msc/src/msc_disk.c
@@ -192,9 +192,6 @@ int32_t tud_msc_read10_cb(uint8_t lun, uint32_t lba, uint32_t offset, void* buff
   // out of ramdisk
   if ( lba >= DISK_BLOCK_NUM ) return -1;
 
-  // Check for overflow of offset + bufsize
-  if ( offset + bufsize >= DISK_BLOCK_SIZE ) return -1;
-
   uint8_t const* addr = msc_disk[lba] + offset;
   memcpy(buffer, addr, bufsize);
 

diff --git a/examples/device/cdc_msc_freertos/src/msc_disk.c b/examples/device/cdc_msc_freertos/src/msc_disk.c
@@ -191,8 +191,6 @@ int32_t tud_msc_read10_cb(uint8_t lun, uint32_t lba, uint32_t offset, void* buff
 
   // out of ramdisk
   if ( lba >= DISK_BLOCK_NUM ) return -1;
-  // Check for overflow of offset + bufsize
-  if ( offset + bufsize >= DISK_BLOCK_SIZE ) return -1;
 
   uint8_t const* addr = msc_disk[lba] + offset;
   memcpy(buffer, addr, bufsize);