Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI idea] Create some margin between login button and scrollbar #4618

Closed
TiBiBa opened this issue Oct 11, 2023 · 0 comments · Fixed by #5325
Closed

[UI idea] Create some margin between login button and scrollbar #4618

TiBiBa opened this issue Oct 11, 2023 · 0 comments · Fixed by #5325
Assignees
@TiBiBa @Annelein

Comments

@TiBiBa
Copy link
Collaborator

TiBiBa commented Oct 11, 2023

Idea incl level
When using Hedy on a smaller screen there is no margin in the top navigation bar. This gives the UI a bit of a crowded feeling and it would be nice to make sure the login button goes with a bit of space between the side of the browser.

Scherm­afbeelding 2023-10-11 om 10 26 42
@TiBiBa TiBiBa self-assigned this Oct 11, 2023
@Annelein Annelein mentioned this issue Mar 27, 2024
Merged
@Annelein Annelein moved this to Ready for Review in Hedy organization board Mar 27, 2024
@mergify mergify bot closed this as completed in #5325 Mar 28, 2024
mergify bot pushed a commit that referenced this issue Mar 28, 2024
@Annelein
💻 Margin login, cheatsheet and language buttons and scrollbar (#5325)
0506286 
Fixes #4618 , I've also added some margin to the _cheatsheet dropdown button_ and the _language dropdown button_ so that those look nicely aligned. 

**How to test**
On a small screen, see if the buttons have a bit more space between them and the scrollbar so that it looks less crowded.

<img width="345" alt="Screenshot 2024-03-27 at 15 09 44" src="https://github.com/hedyorg/hedy/assets/48122190/3788d75a-9dce-4fb0-9383-8986cada4f1f">

<img width="345" alt="Screenshot 2024-03-27 at 15 10 04" src="https://github.com/hedyorg/hedy/assets/48122190/2c00058a-47cb-49ab-bb13-6fe903bec452">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TiBiBa TiBiBa

@Annelein Annelein

Labels
None yet
Projects
Hedy organization board
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

💻 Margin login, cheatsheet and language buttons and scrollbar hedyorg/hedy
2 participants
@TiBiBa @Annelein