You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
#4913 and #4920 removed start_code from content (and needed to be merged to reopen Weblate) but the code still has a few references:
There are a number of other places where start_code is still referenced. Are you interested in removing these as well, or do you just want the current PR shipped?
We're not using `start_code` anymore for Adventures, but there is still a field called `start_code` in the back-end to front-end communication.
Rename that field to `editor_contents` to more clearly indicate its purpose.
Finally remove `start_code` from a couple of places where it explicitly meant the `start_code` in the YAML.
This change also made `editor_contents` have a default value so it doesn't need to be passed when instantiating `Adventure()`. That requires making the fields after it have defaults as well, or moving the field around. Because there was an instantiating of `Adventure('start', 'start', 'start', 'start', code, False, False)`, changing the field order was too dangerous. That code probably shouldn't have been allowed in the first place, so also add a decorator to make it required to pass all fields as keyword arguments (instantiation will fail if positional arguments are used).
Fixes#4922
**How to test**
This PR did not make any functional changes. Everything should still work as before.
#4913 and #4920 removed start_code from content (and needed to be merged to reopen Weblate) but the code still has a few references:
There are a number of other places where
start_code
is still referenced. Are you interested in removing these as well, or do you just want the current PR shipped?Originally posted by @rix0rrr in #4920 (comment)
The text was updated successfully, but these errors were encountered: