Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 My_programs and public_profile design #5386

Open
Annelein opened this issue Apr 8, 2024 · 4 comments
Open

💻 My_programs and public_profile design #5386

Annelein opened this issue Apr 8, 2024 · 4 comments
Assignees
Labels
frontend Issue with the web interface

Comments

@Annelein
Copy link
Contributor

Annelein commented Apr 8, 2024

#5278 implements that only programs that are modified are counted as "programs saved".

But this "programs saved" is old legacy. Because now only modified programs are counted, so it should be changed to something like "programs tried".

This is what my_programs looks like now:
Screenshot 2024-04-08 at 14 12 15

The search boxes and the "programs tried" part should look be coherent to public_profile. The only difference between the two pages would be the parts that have to do with a profile, because my_programs can be seen without a having your profile set to public, so:

  • 'This is a personal text'
  • The avatar / profile picture on the left
Screenshot 2024-04-08 at 14 11 03

@gisellandrade can you propose a design for this? Let me know if there is something you don't understand!

@Annelein Annelein added the frontend Issue with the web interface label Apr 8, 2024
@Annelein Annelein self-assigned this Apr 8, 2024
@Annelein Annelein changed the title 💻 Programs count design 💻 My_programs and public_profile design Apr 8, 2024
@gisellandrade
Copy link
Collaborator

Thank you so much for the explanation, I'll be working on this. I'm thinking about redesigning this ❤️

@Annelein
Copy link
Contributor Author

Annelein commented Apr 8, 2024

Thank you so much for the explanation, I'll be working on this. I'm thinking about redesigning this ❤️

Yes a redesign would be amazing!

@Annelein Annelein moved this to In Progress in Hedy organization board Apr 8, 2024
mergify bot pushed a commit that referenced this issue Apr 23, 2024
Fixes #5193 
Fixes #5192 
Fixes #1275

This fixes that only the programs which are modified are counted as (for now) programs saved.
[This](#5386) is the new issue for the design that shows this counter (where programs_saved will be changed):


**Also solved that only if a program is modified, the confetti button is shown:**

https://github.com/hedyorg/hedy/assets/48122190/dd0e6fe2-5484-4192-8f92-be01d1d5607e


How to test:
- Run a program with preview code, make sure it doesn't get added to my-programs
- Run a program with 'modified code' so not the preview code and make sure it does get added to my programs
- Remove a program from my programs and make sure the counter and the options in the forms get properly updated
@Annelein Annelein moved this from In Progress to Planned in Hedy organization board May 14, 2024
@Felienne
Copy link
Member

@AnneliesVlaar and @MarleenGilsing: is this still needed or is this superseded by all the other new designs?

@AnneliesVlaar
Copy link
Collaborator

It should be superseded by the new designs, but I didn't had it on my radar. I will assign myself to keep it on the radar.

@AnneliesVlaar AnneliesVlaar self-assigned this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issue with the web interface
Projects
Status: Planned
Development

No branches or pull requests

4 participants