-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Creating Tags #4688
[UI] Creating Tags #4688
Conversation
for more information, see https://pre-commit.ci
Hi, Hasan! Is this PR still in progress? If so, can you mark it as a Draft? That way is easier for me and Felienne to know which PRs to take a look first. |
Thanks @hasan-sh, I will try to take a look today! |
Tagging works great @hasan-sh! I have one question though, if a teacher adds a tag, should we search the existing tags and suggest these? Otherwise I worry a bit we will soon have "grade 7" and "7th grade" etc. So I would prefer the add box to also be a search box suggesting similar tags: ![]() If you are planning to do this in a separate PR, that is also totally fine by me! Then let's merge this and open an issue for the search within the tagging (which is different from search adventures by tag) |
(also, note to self, we should not forget to add this table on test and prod!) |
This should be good to go when I have merged Weblate! |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Grrrrr that "depends-on" syntax of Mergify did not do the job :( |
Stap one of the (content-management) improvement.
Fixes #4603
Depends-on #4722
Features
customize-adventure
view