Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] prevent students being in multiple classes #4901

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

hasan-sh
Copy link
Contributor

@hasan-sh hasan-sh commented Dec 13, 2023

Fixes #4811

How to test

  • by username: invite a new student to the class.
  • by link: copy the class invite link. Then switch to a student account and paste it in the browser.
  • in both cases, an error should inform you that this student cannot join this class currently

@ghost
Copy link

ghost commented Dec 13, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@hasan-sh hasan-sh marked this pull request as ready for review December 13, 2023 17:11
@hasan-sh hasan-sh requested a review from Felienne December 13, 2023 17:11
@Felienne Felienne changed the title [BUG] prevent sutdents being in multiple classes [BUG] prevent students being in multiple classes Dec 14, 2023
Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hasan-sh!

I can't test this locally since it has the broken css files, and because of the conflicts I can't update. Can you fix the updates so I can test?

@Felienne
Copy link
Member

Hi @hasan-sh!

I guess the easiest quick fix here (what I usually do in this type of situations where all po files have the same due to a new key) is to accept all changes from main with --theirs and then run pybabel extract again.

@Felienne
Copy link
Member

Ah and it seems that you used the no header option on this pr originally too:
image

So if you run the codes again do include the header.

let me know if you need further help!

@Felienne
Copy link
Member

Hi @hasan-sh!

Trying with an invite indeed gives the right error, but joining though a link shows:

image

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hasan-sh!

The po issues have been solved in main, so this can go in!

Copy link
Contributor

mergify bot commented Dec 19, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 87f961c into main Dec 19, 2023
@mergify mergify bot deleted the prevent-students-multiple-classes branch December 19, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Prevent students from joining a second class
2 participants