[CHORE] Check .po files for accidental wrapping #4930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translations in the `.po` files should never be wrapped. When we extract them, we configure `--no-wrap`, and we also configure Weblate to never wrap them. However, for a reason we don't understand, wrapping still occurred. Add a test to detect this so we don't run into the problem again.
|
Perfect, this fails :) |
mergify bot
pushed a commit
that referenced
this pull request
Dec 19, 2023
In #4767 we have unwrapped all po files hoping to never ever again have annoying issues. It went well for a while, but.... for reasons I can't understand, #4878 again wrapped the po files :( <img width="1470" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/e7375971-a41f-4746-ba94-b230a6d524ae"> This unwraps everything Additionally, @rix0rrr created #4930 which adds a test to test for accidental unwrapping. That will not solve the issue but will 1) prevent issues and 2) might help us to understand when it goes wrong and with that why.
|
Cool, let's see if this passes now that #4929 is merged! |
Ah there are some strings that have a (wanted) newline like email content: 
And I see now some strings are also empty, which I guess we'd like to catch too in a test? 
(but only in English, not in other languages, because Weblate will copy it over) |
for more information, see https://pre-commit.ci
…o check-pofiles-wrapping
Felienne
approved these changes
Dec 20, 2023
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translations in the
.pofiles should never be wrapped. When we extract them, we configure--no-wrap, and we also configure Weblate to never wrap them.However, for a reason we don't understand, wrapping still occurred in #4878.
Add a test to detect this so we don't run into the problem again.