💻 variable list appearing automatically (clone) #5499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felienne
approved these changes
May 2, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
May 28, 2024
Fixes #5499 When the language of Hedy is set to Arabic, numbers should be displayed in Arabic numbers regardless of what alphabet was used in the input. This PR fixes the corner case in which when literal numbers are printed, they are not converted to Arabic. ** How to test** Run Hedy locally, navigate to level 6 and switch the language to Arabic. Execute the following piece of code and ensure that both lines print the result `٢`: ``` print 1 + 1 print 2 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same work done in #5481 with some minor changes (see comments). Also, we really needed this PR to be merged, therefore, we created a clone version.
So, credit to @bellacolombarolli00 and @JoseArtur!