-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪲 Fix list printing #5716
🪲 Fix list printing #5716
Conversation
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Welp the test are failing, and I think it might be because of the automatically generated files? It's the only thing I see is different between your first commit, and the subsequent ones. |
tests/test_python_prefixes.py
Outdated
value_str_test_data = [ | ||
(Value('hello Hedy'), 'hello Hedy'), | ||
(Value(1, num_sys='Latin'), '1'), | ||
(Value(True, bools={True: 'yes', False: 'no'}), 'yes'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I think this is the problem. PyLint is saying that there's no bools
keyword argument in the constructor. I think it's supossed to be bool_sys
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh no! You are totally right! This is a merging failure on my end. Thanks for investigating, I will fix it right away!
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #5714
Address printing lists.
How to test
Go to level 16 and execute the following program. Ensure that there are no errors and the list is printed.