Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Fix list printing #5716

Merged
merged 6 commits into from
Aug 26, 2024
Merged

🪲 Fix list printing #5716

merged 6 commits into from
Aug 26, 2024

Conversation

boryanagoncharenko
Copy link
Collaborator

Fixes #5714
Address printing lists.

How to test
Go to level 16 and execute the following program. Ensure that there are no errors and the list is printed.

mylist = [1, 2, 3]
print mylist

Copy link
Contributor

mergify bot commented Aug 23, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@jpelay
Copy link
Member

jpelay commented Aug 23, 2024

Welp the test are failing, and I think it might be because of the automatically generated files? It's the only thing I see is different between your first commit, and the subsequent ones.

value_str_test_data = [
(Value('hello Hedy'), 'hello Hedy'),
(Value(1, num_sys='Latin'), '1'),
(Value(True, bools={True: 'yes', False: 'no'}), 'yes'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I think this is the problem. PyLint is saying that there's no bools keyword argument in the constructor. I think it's supossed to be bool_sys?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no! You are totally right! This is a merging failure on my end. Thanks for investigating, I will fix it right away!

Copy link
Contributor

mergify bot commented Aug 26, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 994d4e4 into main Aug 26, 2024
12 checks passed
@mergify mergify bot deleted the print_list_5714 branch August 26, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Printing a list gives an error
2 participants