Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚚 Support 'begins_with' condition in Dynamo #6031

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

rix0rrr
Copy link
Collaborator

@rix0rrr rix0rrr commented Dec 9, 2024

Add support for the DynamoDB 'begins_with' condition. This condition can be used on sort keys for efficient lookup, or on non-key fields for inefficient (but convenient) filtering.

Also in this PR:

  • Rename filter to server_side_filter for get_many; this doesn't remove the old argument but it is considered deprecated starting today.
  • Rewrite the documentation about server side filtering to be a bit more clear.

How to test

No functional changes, so nothing to test.

Add support for the DynamoDB 'begins_with' condition. This condition can
be used on sort keys for efficient lookup, or on non-key fields for
inefficient (but convenient) filtering.

Also in this PR:

- Rename `filter` to `server_side_filter` for `get_many`; this doesn't
  *remove* the old argument but it is considered deprecated starting
  today.
- Rewrite the documentation about server side filtering to be a bit
  more clear.
@rix0rrr rix0rrr requested a review from jpelay December 9, 2024 08:17
@jpelay jpelay self-assigned this Dec 9, 2024
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot Rico!

Copy link
Contributor

mergify bot commented Dec 9, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 16058b2 into main Dec 9, 2024
11 checks passed
@mergify mergify bot deleted the begins-with-condition branch December 9, 2024 20:45
boryanagoncharenko pushed a commit that referenced this pull request Dec 10, 2024
Add support for the DynamoDB 'begins_with' condition. This condition can be used on sort keys for efficient lookup, or on non-key fields for inefficient (but convenient) filtering.

Also in this PR:

- Rename `filter` to `server_side_filter` for `get_many`; this doesn't *remove* the old argument but it is considered deprecated starting today.
- Rewrite the documentation about server side filtering to be a bit more clear.

**How to test**

No functional changes, so nothing to test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants