feat/fix(ssr): Fix hydration errors, remove need for resetServerContext when useId is available (i.e. React 18+) #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (i.e. React 18+)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
klarstrup
changed the title
klarstrup
changed the title
|
This looks good to me. @100terres do you wanna take a second look? |
5 tasks
|
Thank you @klarstrup for your contribution! I wanted to do some changes, but I wasn't able to do it directly on your branch. I've open a new pull request with your changes 🙂 Follow this pull request ➡️ #439 |
|
#439 has been merged! Thank you again 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes hydration errors of the sort:
Even with proper usage of
resetServerContext(), this error can crop up when doing sufficiently concurrent SSR.It also adds a warning for when
resetServerContextis called unnecessarily.Following the addition of React 18 support the resettable hacky increment-only IDs can be dropped in favor of the first party
useId()API (details: https://reactjs.org/docs/hooks-reference.html#useid)This should not be a breaking change per se but the new IDs could result in broken snapshot tests among consumers, as indeed it did here.