-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release v2.5.0 #319
Conversation
9b804b2
to
4eb3c82
Compare
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
4eb3c82
to
15c221f
Compare
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Thanks @davidkarlsen for bringing up in keybase chat. chart-testing Circle project was disabled. We could either backport or handle the release manually. But we should probably address circle on this branch by removing it if we don't backport. CC @unguiculus other thoughts on this? |
Sorry I wish I had a better answer. I just think we should address the dev-v2 release CI correctly and transparently however we feel it's worth the time to do it. |
I can backport the ci release part to this PR, and then we can release using the automation |
This will probably be one last release for v2. I'd do it manually and not bother with CircleCI. |
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato / @unguiculus - Any chance we could get 2.5.0 out the door? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamping
@cpanato ah right, this was was on hold for so long because when we last discussed we all said let's just do a manual release. I don't have any problem with this PR though if it works. It looks ok from a quick review, I just can't test it right now so rubber stamping if you want to take on making sure it runs/tags 2.x ok and fix as needed ❤️
ok, I did not quite remember this but spend some time to remember back :) this will be the last release for helm v2 |
What this PR does / why we need it:
last chart-testing release for helm v2, that contains the last helm v2 bump to use the final helm v2 (2.17.0) which drops the stable repo from the initialization (which was redirected to another URL)
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: