Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare release v2.5.0 #319

Merged
merged 3 commits into from
Aug 19, 2021
Merged

Prepare release v2.5.0 #319

merged 3 commits into from
Aug 19, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 21, 2021

What this PR does / why we need it:
last chart-testing release for helm v2, that contains the last helm v2 bump to use the final helm v2 (2.17.0) which drops the stable repo from the initialization (which was redirected to another URL)

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@scottrigby
Copy link
Member

Thanks @davidkarlsen for bringing up in keybase chat. chart-testing Circle project was disabled. We could either backport or handle the release manually. But we should probably address circle on this branch by removing it if we don't backport.

CC @unguiculus other thoughts on this?

@scottrigby
Copy link
Member

Sorry I wish I had a better answer. I just think we should address the dev-v2 release CI correctly and transparently however we feel it's worth the time to do it.

@cpanato
Copy link
Member Author

cpanato commented Jan 21, 2021

I can backport the ci release part to this PR, and then we can release using the automation

@scottrigby

@unguiculus
Copy link
Member

This will probably be one last release for v2. I'd do it manually and not bother with CircleCI.

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@ktham
Copy link

ktham commented Aug 11, 2021

@cpanato / @unguiculus - Any chance we could get 2.5.0 out the door?

Copy link
Member

@scottrigby scottrigby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamping

@cpanato ah right, this was was on hold for so long because when we last discussed we all said let's just do a manual release. I don't have any problem with this PR though if it works. It looks ok from a quick review, I just can't test it right now so rubber stamping if you want to take on making sure it runs/tags 2.x ok and fix as needed ❤️

@cpanato
Copy link
Member Author

cpanato commented Aug 19, 2021

ok, I did not quite remember this but spend some time to remember back :)

this will be the last release for helm v2

@cpanato cpanato merged commit bd40619 into helm:dev-v2 Aug 19, 2021
@cpanato cpanato deleted the prepare-v2release branch August 19, 2021 08:59
@cpanato
Copy link
Member Author

cpanato commented Sep 3, 2021

released: https://github.com/helm/chart-testing/releases/tag/v2.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants