Load GITHUB_PATH in PATH to use correct binaries when creating registry #133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
kind.sh
installs 'kubectl' and 'kind', they are put inGITHUB_PATH
which makes them discoverable for the next steps in the pipeline, but not for other scripts in the same step, likeregistry.sh
for example.The reason it currently works is that 'kubectl' and 'kind' are already present in Github Action's image. This means that regardless what the actions installs,
registry.sh
will always use the versions provided by the GH runner.The version mismatch can potentially cause some issues when running in Github Actions, but completely breaks the pipeline when using local runner like
nektos/act
where 'kubectl' might not exist in the first placeHere is a more verbose debugging version of this PR that shows what binaries are used at each stage where you can see that when
registry.sh
startswhich -a kubectl
reports:and after
GITHUB_PATH
is loadedThe approach in this PR is just one way to do it. I am looking for comments and suggestions on what would be a better way to fix the issue (or even if you consider it an issue at all).