Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "base image" terminology #457

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Use "base image" terminology #457

merged 2 commits into from
Jan 22, 2024

Conversation

colincasey
Copy link
Contributor

This is part of the Rename stack image to base image epic.

The Heroku term "stack" is overloaded. To reduce confusion, we will rename "stack image" to "base image".

W-14866121

@colincasey
Use "base image" terminology
8140425 
This is part of the [Rename stack image to base image](https://gus.lightning.force.com/lightning/r/ADM_Epic__c/a3QEE000000jgBB2AY/view) epic.
> The Heroku term "stack" is overloaded. To reduce confusion, we will rename "stack image" to "base image".

[W-14866121](https://gus.lightning.force.com/lightning/r/a07EE00001ie1mxYAA/view)
@colincasey colincasey requested a review from a team as a code owner January 22, 2024 15:16
edmorley
edmorley approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I also see there are "Build-time" and "Run-time" references in the table headings, from which we could remove the "-time" - similar to the changes made in the base-images repo)

@colincasey colincasey merged commit ae6dad1 into main Jan 22, 2024
42 checks passed
@colincasey colincasey deleted the use_base_image_terminology branch January 22, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colincasey @edmorley