Use a consistent branch name when opening PRs #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the automation included the buildpack release version in the branch name used for both the "Prepare release" and "Update builder" PRs. For example: `prepare/v0.1.7` `update/heroku/buildpacks-go/0.1.7` This meant that multiple PRs can end up being opened, for example if: - Someone triggers a "Prepare release" PR, but then triggers another with a different bump level (such as if they realised they had chosen the wrong version bump initiall) - The "Update builder" PR is not merged for one release, before the next release occurs (as seen in ). Now, the branch names no longer include the buildpack version, for example: `prepare-release` `update/heroku/buildpacks-go` ...meaning that the initial PR gets updated instead, per: https://github.com/peter-evans/create-pull-request#action-behaviour
colincasey
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the automation included the buildpack release version in the branch name used for both the "Prepare release" and "Update builder" PRs.
For example:
prepare/v0.1.7update/heroku/buildpacks-go/0.1.7This meant that multiple PRs can end up being opened, for example if:
Now, the branch names no longer include the buildpack version, for example:
prepare-releaseupdate/heroku/buildpacks-go...meaning that the initial PR gets updated instead, per:
https://github.com/peter-evans/create-pull-request#action-behaviour
GUS-W-13907279.