Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrades and testing #19

Merged
merged 1 commit into from
Nov 27, 2017
Merged

upgrades and testing #19

merged 1 commit into from
Nov 27, 2017

Conversation

tcrowe
Copy link
Contributor

@tcrowe tcrowe commented Nov 20, 2017

In this PR:

  • npm modules upgraded
  • gulp removed
  • mocha tests added
  • coverage 100%

How to test:

git clone https://github.com/tcrowe/hexo-browsersync.git
cd hexo-browsersync
git checkout upgrading
npm install
npm test

screen shot 2017-11-20 at 7 31 04 am

@NoahDragon
Copy link
Member

Thank you for the awesome contribution. One little thing, could you please remove the package-lock.json file?

@tcrowe
Copy link
Contributor Author

tcrowe commented Nov 27, 2017

Yes @NoahDragon no problem. Do we need a version change? If so, which version?

@tcrowe
Copy link
Contributor Author

tcrowe commented Nov 27, 2017

Maybe that's best done by the person doing npm version ... 😄

@NoahDragon
Copy link
Member

@tcrowe thank you. Yeah, will let npm version to decide. 😄

@NoahDragon NoahDragon merged commit bc1b47d into hexojs:master Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tcrowe @NoahDragon