spotify: remove hardcoded ip for ap-gew4.spotify.com #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IP address seems to have changed and this now causes issues, I've no idea why it should be hardcoded in the first place but was done with commit: e2faba2 Signed-off-by: Brendan Le Foll <brendan@fridu.org>
|
note this can apply directly to the development branch too, I can do a PR for that too if preferred. |
|
Please create a PR for the development branch and I'll merge it. |
|
closing this in favour of #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IP address seems to have changed and this now causes issues, I've no idea why it should be hardcoded in the first place but was done with commit: e2faba2
Feel free to just revert original commit instead!