-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize publications using Zotero API #474
Conversation
I don't want to put this on anyone... but if someone has the time to review that would be awesome @sehilyi @dvdkouril |
@@ -18,7 +18,7 @@ <h3>Abstract</h3> | |||
{% endif %} | |||
|
|||
<h3>Citation</h3> | |||
{% capture citation %}{{ page.cite.authors }}. “{{ page.title }}” {{ page.cite.published }} ({{ page.year }}).{% endcapture %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the rendering of the citation such that there is a doi link, e.g.:
"T Manz and N Gehlenborg. Fancy Journal 4(10):1-4 doi:example-doi (2024)."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only for the detail page, right? Would it make sense to have the DOI links also in the list view at hidive.org/publications? Some of the newer preprints have that there even now, without a clickable link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. That would be awesome.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can make a separate PR to update the publications-rows.html
accordingly (or add to this PR).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ I already edited that file to apply the rich formatting of the text from the yaml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hows this? @ngehlenborg @dvdkouril
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manzt Could we format the publications like this:
I.e., period after author list, comma after title, year after venue, doi at the very end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup. I'm on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a future TODO, but would could have a lab CSL which formats in your preferred style. You can supply a custom CSL to the Zotero API.
I'd experimented with this approach over the weekend (adapted from Nature Publishing Group - Vancouver) but it felt like a separate rabbit hole. https://github.com/manzt/hidive-pubs/blob/12e517c6ddf0713628b6dfb001c56862c27b7b1e/assets/hidive.csl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly just tried to understand the workflow and randomly saw small things that could be improved. However, most of them seem anyway on the responsibility of the Zotero entries, if I understand correctly.
I think this is ready to merge. |
Let me now do just a final quick pass looking at the author names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry can you approve this again... I added #475 which was merged before thi... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Ok... this PR serves two primary purposes.
The main thing is that it links our existing publications here by Zotero ID to entries on Zotero. And second it makes an attempt to standardize the formatting of authors and publishing.