Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optional token in checkout and in comment-pr #298

Conversation

NikitaCOEUR
Copy link
Contributor

This pull request includes updates to the actions/checkout and actions/create-or-update-comment GitHub Actions to add new input parameters and improve functionality. The most important changes are the addition of new token parameters and the ability to specify a comment author.

Updates to actions/checkout:

  • Added a token input parameter to specify a custom token for checking out the repository, which will disable persist-credentials if provided. (actions/checkout/README.md, actions/checkout/action.yml) [1] [2] [3] [4]

Updates to actions/create-or-update-comment:

  • Added comment-author and token input parameters to specify the comment author and an optional token for GitHub API interactions. (actions/create-or-update-comment/README.md, actions/create-or-update-comment/action.yml) [1] [2] [3] [4] [5]

- Specifying token here will force persist-credentials to false for
security reason but let it true as default to ensure backward
compatibility.
- Optional token to interact with GitHub API
- Optional comment-author to overwrite github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for creating your PR, we will check it out very soon

@neilime neilime merged commit ba4d18c into hoverkraft-tech:main Feb 9, 2025
13 checks passed
@neilime
Copy link
Contributor

neilime commented Feb 9, 2025

Thanks @NikitaCOEUR for this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants