Feat/numbers #203
Merged
Feat/numbers #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bewee
approved these changes
Jun 11, 2021
There was a problem hiding this comment.
Since @TheGrayStone asked me to review this, I quickly self-assigned and marked it as ready.
The feature looks good and works fine, great work. I only had some minor remarks you might want to have a look at before merging.
packages/Algernon.package/ALGCore.class/instance/ifShouldHandleAsQuickAccess.do..st
Outdated
Show resolved
Hide resolved
packages/Algernon.package/ALGCore.class/class/setQuickAccessModifier..st
Outdated
Show resolved
Hide resolved
packages/Algernon.package/ALGItemProvider.class/instance/searchAllItemsFor..st
Outdated
Show resolved
Hide resolved
packages/Algernon.package/ALGResultList.class/instance/add.target.selector.argumentList..st
Outdated
Show resolved
Hide resolved
…hAllItemsFor..st Co-authored-by: Benedikt Weber <44091658+bewee@users.noreply.github.com>
…difier..st Co-authored-by: Niklas Mohrin <47574893+niklasmohrin@users.noreply.github.com>
…eAsQuickAccess.do..st Co-authored-by: Benedikt Weber <44091658+bewee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #189