Windows: Prevent applying -1 as inset space #12801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visually the screen representation still bounces from time to time when center is spammed, but now it returns instantly on it's own and keeps the proper position. It also is correct when manually placing around, previously it was getting some small weird ofset at least on windows and didn't fit on the display border representation exactly. So I guess it's all fixed now at least AFAICT on windows, thanks. |
|
Doh! Nice catch :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the root cause of the drift and weird offsetting.
That said, I still think it's probably more correct to apply the offset to the anchor position in the layout editors.
-[Unknown]