Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 字典项id默认根据字典id及ordinal生成 #270

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

goten7
Copy link
Contributor

@goten7 goten7 commented Jan 22, 2024

No description provided.

}));
}

private void generateId(DictionaryItemEntity item) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

写到DictionaryItemEntity里?

@zhou-hao
Copy link
Member

测试是否覆盖一下场景:

  1. 不传入 ordinal的场景
  2. 传入错误的ordinal的场景(如有重复的)

@zhou-hao zhou-hao merged commit b226e6c into hs-web:master Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants