Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safari not supported #98

Closed
aaraney opened this issue Jan 19, 2022 · 1 comment · Fixed by #99
Closed

Safari not supported #98

aaraney opened this issue Jan 19, 2022 · 1 comment · Fixed by #99
Assignees
@aaraney
Labels
bug Something isn't working frontend Issue requires frontend code change

Comments

@aaraney
Copy link
Member

aaraney commented Jan 19, 2022

Known bug that the frontend does not support safari at the moment. Will work to resolve this soon, hopefully in the next day or so.
@aaraney aaraney added bug Something isn't working frontend Issue requires frontend code change labels Jan 19, 2022
@aaraney aaraney self-assigned this Jan 19, 2022
@aaraney
Copy link
Member Author

aaraney commented Jan 25, 2022

The issue is present due to the use of Array.prototype.at(). It is used several times in ResourcePage to, for example, split apart the basename of a file. CanIUse shows that this js array built-in is not supported on Safari <= 15.2 (so pretty much all current safari versions that are not in beta/bleeding edge).

aaraney pushed a commit to aaraney/hydroshare_jupyter_sync that referenced this issue Jan 26, 2022
remove usage of array.at method. is not safari <= 15.2 compatible.
c2bb9be 
see caniuse and hydroshare#98 for more detail. https://caniuse.com/mdn-javascript_builtins_array_at
@aaraney aaraney mentioned this issue Jan 26, 2022
Merged
aaraney pushed a commit that referenced this issue Jan 26, 2022
remove usage of array.at method. is not safari <= 15.2 compatible.
a186bf2 
see caniuse and #98 for more detail. https://caniuse.com/mdn-javascript_builtins_array_at
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaraney aaraney

Labels
bug Something isn't working frontend Issue requires frontend code change
Projects
None yet
Milestone
No milestone
1 participant
@aaraney