-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: #3268 Globally unique item identifiers #3317
Merged
mversic
merged 3 commits into
hyperledger-iroha:iroha2-dev
from
mversic:globally_unique_item_identifiers
Apr 7, 2023
Merged
[refactor]: #3268 Globally unique item identifiers #3317
mversic
merged 3 commits into
hyperledger-iroha:iroha2-dev
from
mversic:globally_unique_item_identifiers
Apr 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0fa9530
to
4570923
Compare
mversic
commented
Mar 21, 2023
mversic
commented
Mar 21, 2023
4570923
to
fdebbc2
Compare
Codecov Report
@@ Coverage Diff @@
## iroha2-dev #3317 +/- ##
==============================================
- Coverage 62.33% 54.35% -7.98%
==============================================
Files 169 162 -7
Lines 31218 31339 +121
==============================================
- Hits 19459 17034 -2425
- Misses 11759 14305 +2546
... and 37 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
fe4de64
to
39ec2cf
Compare
225f37c
to
f25f4f3
Compare
e48d8a5
to
cf40a4c
Compare
06630e8
to
3f2c9e2
Compare
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
949d5ca
to
7f1ac77
Compare
0x009922
reviewed
Apr 7, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
7f1ac77
to
80a3d1f
Compare
0x009922
approved these changes
Apr 7, 2023
Erigara
approved these changes
Apr 7, 2023
This was referenced Apr 27, 2023
appetrosyan
pushed a commit
that referenced
this pull request
Jun 5, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
mversic
added a commit
that referenced
this pull request
Oct 17, 2023
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Rename items so that their names are globally unique within
Iroha
workspaceCloses #3268
Issue
Attaching
#[no_mangle]
to exported function whose name is derived based on the name of the struct was causing collisions. This was the preferred solution.Benefits
Possible Drawbacks
we might want to consider implementing some tests to make sure
iroha_schema::TypeId
is unique for every type in the codebaseUsage Examples or Tests [optional]
Alternate Designs [optional]
In addition to this we can also consider implementing a hook for custom naming exported functions