first-network/scripts/*: Make Chaincode name configurable #132
Conversation
maniankara
requested review from
christo4ferris,
denyeart,
harrisob,
jyellick,
lehors,
mastersingh24,
mbwhite and
sstone1
as code owners
|
You'll need to do the same for |
|
You can test this by doing |
1. The idea is to use this generic functions for managing any chaincode lifecycle inside cli container. E.g. ''' source scripts/utils.sh packageChaincode 1 0 1 myapp installChaincode 0 1 myapp approveForMyOrg 1 0 1 myapp .... ''' Signed-off-by: Anoop Vijayan Maniankara <anoop@tuxera.com>
maniankara
force-pushed
the
scripts_improvement
branch
from
aa6c781 to
0307743
Compare
|
@btl5037 Ah yes. Had missed that. Thanks, |
|
Thanks for the quick response @maniankara I'll take a look at it later tonight! |
|
LGTM, tested locally and ran as expected, backwards functionality remains intact |
| @@ -15,12 +15,14 @@ CC_SRC_LANGUAGE="$3" | |||
| TIMEOUT="$4" | |||
| VERBOSE="$5" | |||
| NO_CHAINCODE="$6" | |||
| NAME="$7" | |||
There was a problem hiding this comment.
I think CC_NAME would be more descriptive and consistent with other variables like CC_SRC_LANGUAGE and while this adds an argument to this script specifying that argument requires editing byfn.sh, doesn't it?
On testing I noticed that a simple addition of that argument to byfn.sh doesn't even work because NO_CHAINCODE isn't set and the cc name argument is gobbled up as the NO_CHAINCODE argument.
|
Since byfn (first-network) is being retired soon, let's go ahead and close this PR. |
References #131 #118
Signed-off-by: Anoop Vijayan Maniankara anoop@tuxera.com