Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows dev install #918

Closed
wants to merge 2 commits into from

Conversation

mjadobson
Copy link
Contributor

There were a few errors thrown when trying to set up Slate dev on Windows 10.

This pull request alters the npm scripts so that they will work cross platform. Additionally, it adds a note that windows-build-tools may be required before attempting to install.

@erquhart
Copy link
Contributor

@mjadobson CI build is failing - you'll need to call the mkdirp binary directly. Example:

"build": "./node_modules/mkdirp/bin/cmd.js ./tmp && ..."

Otherwise it seems to work great - awesome improvement!

@mjadobson
Copy link
Contributor Author

That's interesting. Do you know why that's the case? I thought it would have installed the devDeps and been able to run them like it's doing with eslint/browserify/etc

@erquhart
Copy link
Contributor

Yeah that does make sense. Might be yarn, checking.

@erquhart
Copy link
Contributor

erquhart commented Jul 11, 2017

Yep, it's yarn. Very strange. This seems related, not sure it applies to direct dependencies: yarnpkg/yarn#760.

It's only affecting mkdirp in this case. Might be yarn mishandling bin when defined as a path instead of an object (npm-run-all, eslint, and browserify binaries are all mapped out in objects, for example). Seems hitting the bin directly is necessary for now since this project uses yarn.

@brendancarney
Copy link
Collaborator

Closing, as this looks pretty out of date now. If there are still Windows issues, please feel free to update the PR or create an issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants