Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rustfmt license template #189

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Remove rustfmt license template #189

merged 1 commit into from
Jun 21, 2022

Conversation

externl
Copy link
Member

@externl externl commented Jun 21, 2022 •
edited
Loading

This feature has been removed from rustfmt. See rust-lang/rustfmt#5103

@externl
Remove rustfmt license template
1cc768c 
This feature has been removed from rustfmt
InsertCreativityHere
InsertCreativityHere approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@InsertCreativityHere InsertCreativityHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sad that they removed it.

@externl externl merged commit a6f335f into icerpc:main Jun 21, 2022
@externl externl deleted the remove-rustfmt-license-template branch June 21, 2022 18:51
@InsertCreativityHere
Copy link
Member

We should add some logic to the dist-util script to compensate for losing this tool.
Should be pretty trivial to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InsertCreativityHere InsertCreativityHere InsertCreativityHere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@externl @InsertCreativityHere