Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Return more than one economic metric in results #293

Closed
9 of 10 tasks
GabrielSoto-INL opened this issue May 12, 2023 · 0 comments · Fixed by #294
Closed
9 of 10 tasks

[TASK] Return more than one economic metric in results #293

GabrielSoto-INL opened this issue May 12, 2023 · 0 comments · Fixed by #294
Assignees
Labels
priority-normal tasks that may be time sensitive, but are not necessarily critical task Feature requests

Comments

@GabrielSoto-INL
Copy link
Collaborator

GabrielSoto-INL commented May 12, 2023


Issue Description

Describe the solution you'd like
HERON currently only reports back NPV as an economic metric from TEAL, whether mode is opt or sweep. There should be more options for both optimization and sweeping, but still default to NPV. Plus, if we run optimization we should give the option to report back other metrics as well. For now, at least add PI and IRR to the list because NPV search requires more planning.

There should also be a distinction between economic metric and statistical metric. Economic metric should be the NPV, IRR, or PI calculated for all collected cashflows in the inner runs (per realization/sample). Statistical metric should be the operator on the distribution of economic metrics which may or may not be the outer objective function (could just be a returned metric in a sweep). Examples for statistical metrics are expected value, value at risk, variance, etc.


For Change Control Board: Issue Review

This review should occur before any development is performed as a response to this issue.

  • 1. Is it tagged with a type: defect or task?
  • 2. Is it tagged with a priority: critical, normal or minor?
  • 3. If it will impact requirements or requirements tests, is it tagged with requirements?
  • 4. If it is a defect, can it cause wrong results for users? If so an email needs to be sent to the users.
  • 5. Is a rationale provided? (Such as explaining why the improvement is needed or why current code is wrong.)

For Change Control Board: Issue Closure

This review should occur when the issue is imminently going to be closed.

  • 1. If the issue is a defect, is the defect fixed?
  • 2. If the issue is a defect, is the defect tested for in the regression test system? (If not explain why not.)
  • 3. If the issue can impact users, has an email to the users group been written (the email should specify if the defect impacts stable or master)?
  • 4. If the issue is a defect, does it impact the latest release branch? If yes, is there any issue tagged with release (create if needed)?
  • 5. If the issue is being closed without a pull request, has an explanation of why it is being closed been provided?
@GabrielSoto-INL GabrielSoto-INL added task Feature requests priority-normal tasks that may be time sensitive, but are not necessarily critical labels May 12, 2023
@GabrielSoto-INL GabrielSoto-INL self-assigned this May 12, 2023
@PaulTalbot-INL PaulTalbot-INL linked a pull request May 16, 2023 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-normal tasks that may be time sensitive, but are not necessarily critical task Feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant