-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return Multiple Economic Metrics #294
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ings and opt econ metric
…ngs and econ_metrics
tests on windows pass, but not testing multiple metrics yet
…ow includes opt metric
PaulTalbot-INL
requested changes
May 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments to consider.
newest test is taking too long when running as an optimization case. will try switching to a sweep case to avoid timeout error |
PaulTalbot-INL
approved these changes
May 16, 2023
10 tasks
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address?
#293
What are the significant changes in functionality due to this change request?
<metric>
has been renamed to<stats_metric>
to represent the statistical operator to use on the distribution of economic metrics from the inner (e.g., expectedValue, min, value at risk). Existing tests have been updated to reflect this change.<opt_metric>
to represent the TEAL economic metric which we are creating a distribution of in the inner (currently NPV, IRR, PI). this defaults to NPV<EconMetrics>
for additional metrics (NPV, IRR, PI) to return to the user after outer run is completesweep
mode, this defaults to just NPV. otherwise returns all requested metrics from useropt
mode, it returns requested metrics alongside with<opt_metric>
. Does not return duplicates.<return_statistics>
is specified, these statistics are applied to all requested metrics. Otherwise returns the basic statistics as defined within HERON.template_driver.py
to accommodate multiple metricsFor Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.