-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel work to expand usefulness of parallel tag #205
Conversation
These include memory, expectedTime, clusterParameters, and RemoteRunCommand
0f6b3bb
to
cac24f0
Compare
<!-- <internalParallel>True</internalParallel> | ||
<mode>mpi<runQSUB></runQSUB></mode> | ||
<expectedTime>72:0:0</expectedTime> | ||
<clusterParameters>-P nst -j oe</clusterParameters> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we remove this commented code from the outer.xml template file now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's probably a good idea.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. New feature is documented.
FUTURE WORK IDEA: Add use-case examples walkthroughs to the wiki, one for local, one for HPC. Also a debugging workflow.
Pull Request Description
What issue does this change request address?
Closes #204
What are the significant changes in functionality due to this change request?
Expands the parallel tag to allow more features.
Adds a way to just run HERON with an integration test
Adds different defaults for parallel inner and outer size.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.