Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage periodic boundaries for level #313

Merged
merged 1 commit into from
Aug 18, 2023

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Aug 17, 2023


Pull Request Description

What issue does this change request address?

Closes #87.

What are the significant changes in functionality due to this change request?

By default (opt-out available), requires that a storage's final level in an evaluation window be equal to the initial level. While this removes a degree of freedom from optimal dispatch, it also removes the possibility of "free energy" or "free sink" because of boundary condition assumptions.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from dylanjm August 17, 2023 19:39
@PaulTalbot-INL
Copy link
Collaborator Author

Note that we should post this to the discussion board, as it changes default behavior.

@@ -122,6 +122,27 @@
</economics>
</Component>

<Component name="steam_offload">
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note in the original version of this problem, without the periodic level boundary constraint, the steam would fill the storage until the end of the analysis window. Now, since it has to return to original storage level, there's nowhere for the excess steam to go when the "steamer" is size 100, so I added this component as a low-cost steam sink.

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. This new capability will serve as a good default that's easy to explain and I guess could be considered "more realistic."

@dylanjm
Copy link
Collaborator

dylanjm commented Aug 18, 2023

@mgarrouste Here is the PR implementing periodic boundary conditions for storage.

@dylanjm dylanjm merged commit 3e39b8c into idaholab:devel Aug 18, 2023
@dylanjm dylanjm mentioned this pull request Aug 18, 2023
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Setting final storage level
2 participants