HERON Using SyntheticHistory/TSA ROMs

[GabrielSoto-INL]

---

Pull Request Description

What issue does this change request address?

#323

What are the significant changes in functionality due to this change request?

• New versions of the Sine, SineHour, Sine30Yr, and NYISO 2yr ROMs have been added that are trained using the SyntheticHistory module in RAVEN.

• XML files for each are also added in a new TSA subdirectory in the tests folder. An additional XML for the NYISO 20yr is also added but the new pickle file is omitted due to size constraints (~120MB).

• Regolding some regression tests due to small differences in new TSA algorithms within SyntheticHistory compared with the old SupervisedLearning.ARMA module

---

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

• 1. Review all computer code.
• 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
• 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
• 4. Automated Tests should pass.
• 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
• 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
• 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
• 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
• 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

[PaulTalbot-INL]

Changes look okay to me, just one comment to consider

[PaulTalbot-INL]

does this still run the right tests when it's swapped off debug mode?

[GabrielSoto-INL]

yes, the debug mode line should have been commented out in the first place (artifact from copying over/live demo).

also some clarification: these aren't being tested with rook. they could be tested, but the tests would take a very long time. I had meant for this to be resource for people who wanted to run the workshop case in opt mode for reference/comparison.

[PaulTalbot-INL]

Okay, good to know. Would they be covered by heavy tests running, or is there no rook hook for them?

[PaulTalbot-INL]

Checklist passes, waiting on one comment clarification before merging.