Need to find a better way to specify "farm_loc" #328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address?
This is not urgent, it can wait after the idaholab/raven#2235 gets merged.
Without installing FARM plugin through
raven/scripts/install_plugins.py -s FARM
, HERON might occasionally pick up FARM (maybe from previous installation, or existing entries insys.path
?) via the lineimport FARM.src
inHERON/src/validators/Factory.py
.A tentative solution is proposed in this PR, but it may not be the best solution:
farm_loc
usinghutils.get_farm_loc
, and then append it to thesys.path
;sys.path
contains another entry of "FARM", will it cause any confusion?What are the significant changes in functionality due to this change request?
import FARM.src
andfarm_loc = FARM.__path__
,farm_loc = hutils.get_farm_loc(raven_path=raven_path)
to specify the location of FARM.It would be perfect if we can force the code to search the
farm_loc
only, and importFARM_SISO
andFARM_MIMO
from that folder. However, I am unsure how to do this properly...Any advices are appreciated!
Thanks,
Haoyu
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.