Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BayesianOpt fix #344

Merged
merged 6 commits into from
Mar 19, 2024
Merged

BayesianOpt fix #344

merged 6 commits into from
Mar 19, 2024

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Mar 15, 2024


Pull Request Description

What issue does this change request address?

Closes #312 Closes #308

What are the significant changes in functionality due to this change request?

Re-implements Anthoney's original PR with only the changes necessary for BayesianOpt.

More work needs to be done to (1) set BayesianOpt as the default optimizer, (2) convert the workshop cases.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

@PaulTalbot-INL PaulTalbot-INL requested a review from dylanjm March 18, 2024 08:31
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change. I'm honestly suprised we don't have to regold all test files since they will default to BO now and I would expect at least some differences in results.

@PaulTalbot-INL
Copy link
Collaborator Author

One small change. I'm honestly suprised we don't have to regold all test files since they will default to BO now and I would expect at least some differences in results.

They aren't defaulting to BO yet, just this one test. That would be another step, that I haven't had time to do. This at least makes it available.

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pesky typo

restored the n in simulation
Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good to merge and tests have been added to ensure this new feature works as it should.

@dylanjm dylanjm merged commit 09bd1e5 into idaholab:devel Mar 19, 2024
4 checks passed
This was referenced Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] HERON using Bayesian Optimizer
2 participants