-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BayesianOpt fix #344
BayesianOpt fix #344
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small change. I'm honestly suprised we don't have to regold all test files since they will default to BO now and I would expect at least some differences in results.
tests/integration_tests/XML_check/gold/optimization_type_mean_LC_o/outer.xml
Outdated
Show resolved
Hide resolved
They aren't defaulting to BO yet, just this one test. That would be another step, that I haven't had time to do. This at least makes it available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pesky typo
tests/integration_tests/XML_check/gold/optimization_type_mean_LC_o/outer.xml
Outdated
Show resolved
Hide resolved
restored the n in simulation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good to merge and tests have been added to ensure this new feature works as it should.
Pull Request Description
What issue does this change request address?
Closes #312 Closes #308
What are the significant changes in functionality due to this change request?
Re-implements Anthoney's original PR with only the changes necessary for BayesianOpt.
More work needs to be done to (1) set BayesianOpt as the default optimizer, (2) convert the workshop cases.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.