-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing aux parameter in ramping constraint #358
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor request for more clarification in comment
src/dispatch/PyomoRuleLibrary.py
Outdated
@@ -140,7 +140,7 @@ def ramp_rule_down(prod_name, r, limit, neg_cap, t, m, bins=None) -> bool: | |||
# dq is negative, - limit is negative | |||
return delta >= - limit | |||
else: | |||
eps = 1.0 # aux parameter to force binaries to behave, TODO needed? | |||
eps = 1e-6*limit # aux parameter to force binaries to behave |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can expound on your comment a bit more. Things like why would it not behave and why choose such a small number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good to merge.
Pull Request Description
What issue does this change request address?
#357
What are the significant changes in functionality due to this change request?
Auxiliary parameter for binary variables (used only when ramp frequencies are selected by user) is now a smaller value scaling with limit. This prevents the lower bound for ramping to be unintentionally constrained.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.