Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing aux parameter in ramping constraint #358

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

GabrielSoto-INL
Copy link
Collaborator

@GabrielSoto-INL GabrielSoto-INL commented Apr 17, 2024


Pull Request Description

What issue does this change request address?

#357

What are the significant changes in functionality due to this change request?

Auxiliary parameter for binary variables (used only when ramp frequencies are selected by user) is now a smaller value scaling with limit. This prevents the lower bound for ramping to be unintentionally constrained.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large tes.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added, the the analytic documentation must be updated/added.
  • 9. If any test used as a basis for documentation examples have been changed, the associated documentation must be reviewed and assured the text matches the example.

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor request for more clarification in comment

@@ -140,7 +140,7 @@ def ramp_rule_down(prod_name, r, limit, neg_cap, t, m, bins=None) -> bool:
# dq is negative, - limit is negative
return delta >= - limit
else:
eps = 1.0 # aux parameter to force binaries to behave, TODO needed?
eps = 1e-6*limit # aux parameter to force binaries to behave
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can expound on your comment a bit more. Things like why would it not behave and why choose such a small number.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added more explanation to the comments here. Additionally, added a xlsx file to the relevant regression test with some sanity checking for the signs, here is a screenshot:
image

Copy link
Collaborator

@dylanjm dylanjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good to merge.

@dylanjm dylanjm merged commit 290e83f into idaholab:devel Apr 24, 2024
4 checks passed
@GabrielSoto-INL GabrielSoto-INL deleted the rampFix branch April 26, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants