Pass meta to validator #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjm
force-pushed
the
meta-to-validator
branch
from
0344c14 to
7681f0e
Compare
10 tasks
|
Job CentOS 8 on 7681f0e : invalidated by @PaulTalbot-INL new relevant RAVEN merge requires resetting tests |
| @@ -74,6 +74,8 @@ def validate(self, components, dispatch, times, meta): | |||
| for res in info: | |||
| for t, time in enumerate(times): | |||
| current = dispatch.get_activity(comp, res, time) | |||
| if comp.get_interaction().is_type('Storage'): | |||
| init_level = comp.get_interaction().get_initial_level(meta) | |||
There was a problem hiding this comment.
this isn't a required change, but if you have to change something anyway, you could extend this if with and t == 0 just to prevent bad copy-paste mistakes, possibly.
There was a problem hiding this comment.
Okay, I added the additional condition
This commit add the meta variable as a parameter to the Validator class method `validate`.
dylanjm
force-pushed
the
meta-to-validator
branch
from
0c564c5 to
49f1de0
Compare
|
@PaulTalbot-INL This is ready for review. Thanks. |
PaulTalbot-INL
approved these changes
Jan 27, 2021
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address?
Refs #60
What are the significant changes in functionality due to this change request?
This commit add the meta variable as a parameter to the Validator class method
validate.For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.