-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update matplotlib #1984
Update matplotlib #1984
Conversation
Job Test Ubuntu 16 on e5a4361 : invalidated by @joshua-cogliati-inl FAILED: Diff tests/framework/PostProcessors/EconomicRatio/timeDepDataset |
The biggest change to images comes from this change: https://matplotlib.org/stable/users/prev_whats_new/whats_new_3.3.0.html#axes3d-no-longer-distorts-the-3d-plot-to-match-the-2d-aspect-ratio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. Just one minor comment.
@@ -40,9 +40,9 @@ Note all install methods after "main" take | |||
<scipy>1.7</scipy> | |||
<scikit-learn>1.0</scikit-learn> | |||
<pandas>1.3</pandas> | |||
<xarray>0.20</xarray> | |||
<xarray>0.19</xarray> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comment here about the downgrade
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
xarray/backends/plugins.py", line 105, in list_engines entrypoints = entry_points().get("xarray.backends", ()) AttributeError: 'EntryPoints' object has no attribute 'get'
e5a4361
to
fc4ab07
Compare
Once tests are green, this PR can be merged. |
Tests are green. PR can be merged. |
Pull Request Description
What issue does this change request address?
#1972
What are the significant changes in functionality due to this change request?
Updates matplotlib (also downgrades xarray because it was throwing error messages)
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.raven/tests/framework/user_guide
andraven/docs/workshop
) have been changed, the associated documentation must be reviewed and assured the text matches the example.