Revert "Removing SRAW because it has problems installing in windows." #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[like] Congjian Wang reacted to your message:
…________________________________
From: Joshua J. Cogliati ***@***.***>
Sent: Tuesday, November 12, 2024 8:09:10 PM
To: idaholab/raven ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [idaholab/raven] Revert "Removing SRAW because it has problems installing in windows." (PR #2400)
This reverts commit 9daaf55<9daaf55>.
________________________________
Pull Request Description
What issue does this change request address?
What are the significant changes in functionality due to this change request?
This re-adds SRAW so we can check when the server issues are fixed.
________________________________
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
* 1. Review all computer code.
* 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
* 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki<https://github.com/idaholab/raven/wiki/RAVEN-Code-Standards#python> for details.
* 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
* 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
* 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
* 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
* 8. If an analytic test is changed/added is the the analytic documentation updated/added?
* 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.
________________________________
You can view, comment on, or merge this pull request online at:
#2400
Commit Summary
* 6fe3800<6fe3800> Revert "Removing SRAW because it has problems installing in windows."
File Changes
(2 files<https://github.com/idaholab/raven/pull/2400/files>)
* M .gitmodules<https://github.com/idaholab/raven/pull/2400/files#diff-fe7afb5c9c916e521401d3fcfb4277d5071798c3baf83baf11d6071742823584> (3)
* A plugins/SRAW<https://github.com/idaholab/raven/pull/2400/files#diff-e348d51b6aee8a830a21590a9ea30f54e09a4d5118c8e8e75b4edffd9ef37673> (1)
Patch Links:
* https://github.com/idaholab/raven/pull/2400.patch
* https://github.com/idaholab/raven/pull/2400.diff
—
Reply to this email directly, view it on GitHub<#2400>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABX3L37UGQPDF2T453FPHR32AJN6NAVCNFSM6AAAAABRU3VZSGVHI2DSMVQWIX3LMV43ASLTON2WKOZSGY2TGMRRGA4DMMQ>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
This reverts commit 9daaf55.
joshua-cogliati-inl
force-pushed
the
add_sraw
branch
from
6fe3800 to
372ab15
Compare
|
Job Mingw Test on 372ab15 : invalidated by @joshua-cogliati-inl failed in fetch |
|
Job Test Fedora Odd on 372ab15 : invalidated by @joshua-cogliati-inl failed in set python environment with segfault |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9daaf55.
Pull Request Description
What issue does this change request address?
What are the significant changes in functionality due to this change request?
This re-adds SRAW so we can check when the server issues are fixed.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.