Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded get coverage tests script functionality #2431

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

caleb-sitton-inl
Copy link
Collaborator


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

#2430

What are the significant changes in functionality due to this change request?

This expands functionality of the get_coverage_tests script. It is designed to maintain backwards compatibility; the default behavior of both the script as a whole and the getRegressionTests function within it should remain the same (with the exception of some debugging). New options for the script include:

  • The ability to specify the directory in which to look for tests, enabling the use of this script for plugins
  • An option to return either test names (as used by rook) or test input file names
  • A new category by which to filter tests, --get-all-tests, which returns xml, python, and all other tests

For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?
  • 9. If any test used as a basis for documentation examples (currently found in raven/tests/framework/user_guide and raven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.

@moosebuild
Copy link

Job Mingw Test on 6b69b78 : invalidated by @joshua-cogliati-inl

failed in fetch

@caleb-sitton-inl caleb-sitton-inl marked this pull request as draft February 3, 2025 17:54
@caleb-sitton-inl caleb-sitton-inl marked this pull request as ready for review February 6, 2025 15:52
@moosebuild
Copy link

Job Test qsubs sawtooth on 31e3db6 : invalidated by @joshua-cogliati-inl

failed in fetch

@moosebuild
Copy link

Job Mingw Test on 31e3db6 : invalidated by @joshua-cogliati-inl

failed in fetch

1 similar comment
@moosebuild
Copy link

Job Mingw Test on 31e3db6 : invalidated by @joshua-cogliati-inl

failed in fetch

@GabrielSoto-INL GabrielSoto-INL self-requested a review February 24, 2025 15:57
@moosebuild
Copy link

Job Test qsubs sawtooth on e5e0bf1 : invalidated by @GabrielSoto-INL

@moosebuild
Copy link

Job Test qsubs sawtooth legacy on e5e0bf1 : invalidated by @GabrielSoto-INL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants