Fix #1767 #1770
Merged
Fix #1767 #1770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `if then else` syntax expects a block for the `then` and `else` parts. Before this patch, the token `InterpEnd` was not a valid follow up token to end a block. This adds `InterpEnd` as a closing token for blocks, allowing `if then else` in interpolation slices without additional parens.
andrevidela
force-pushed
the
fix-if-then-else-interpolation
branch
from
2f5a18b to
bab3897
Compare
|
Would you like to also include the fix for token printing? |
|
Ah that's a good idea, let's do that quickly, which commit should I cherry-pick? |
hmm, i didn't start to write the code. But it should be just swapping the "multiple string begin" and "string begin" I refered in the issue. |
|
I just fixed it now, commit inc |
Co-authored-by: Andy Lok <andylokandy@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
if then elsesyntax expects a block for thethenandelseparts. Before this patch, the token
InterpEndwas not a validfollow up token to end a block. This adds
InterpEndas a closingtoken for blocks, allowing
if then elsein interpolation sliceswithout additional parens.