-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(si): add specific power quantity #394
Conversation
Specific power is used to represent a power-to-weight ratio, like in vehicles or human power; as in watts per kilogram or ft-lbf/s per pound. Added the `SpecificPower` quantity using the existing `Power` quantity as a guideline. For more information on this quantity, please see a description of [specific power](https://en.wikipedia.org/wiki/Power-to-weight_ratio) on Wikipedia.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I still need to do a more in depth review, and have started test actions in the meantime.
Some of the units have multiple divisions (e.g. erg per second per kilogram). Are these commonly used this way? I've only skimmed the referenced article at this point, but generally multiple divisions avoided: https://www.nist.gov/pml/special-publication-811/nist-guide-si-chapter-6-rules-and-style-conventions-printing-and-using#616
Co-authored-by: Mike Boutin <mike.boutin@gmail.com>
I really only know of specific power's use in |
Oh... that said, I felt it important to include this one... // Less commonly used, but more accurate (reduced) derived unit of specific power.
@square_meter_per_cubic_second: 1.0_E0; "m² · s⁻³", "square meter per cubic second", "square meters per cubic second"; ... because that's the true base unit, even though it's not as commonly used as multiplied by |
Please LMK if there's anything else I can do to help make this one acceptable for merge. And thank you for considering it! |
Could rebase and resolve the |
* Formatting for readability. * Fix conversion factor used for pounds. * Check all units based on the units they are derived from. * Add `check_units_energy` test.
I reviewed and pushed a commit to your fork. Please review, rebase, and squash the commits!
|
Hey, yes, I'll try to get to this today... I'm pretty buried in |
Specific power is used to represent a power-to-weight ratio, like in vehicles or human power; as in watts per kilogram or ft-lbf/s per pound.
Added the
SpecificPower
quantity using the existingPower
quantity as a guideline.For more information on this quantity, please see a description of specific power on Wikipedia.