Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add crystl 1 15 support #464

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add crystl 1 15 support #464

wants to merge 2 commits into from

Conversation

imdrasil
Copy link
Owner

What does this PR do?

Adds support of crystal 1.15

Release notes

Please fill the corresponding section regarding this pull request notes below instead of modifying CHANGELOG.md file. Please remove all redundant sections before posting request.

General

  • add crystal 1.15 support

Model

  • specified converter class in column mapping is resolved globally

View

  • specified converter class in column mapping is resolved globally

@imdrasil imdrasil force-pushed the add-crystl-1-15-support branch from 62e2940 to acb5e11 Compare January 25, 2025 21:43
@crimson-knight
Copy link
Contributor

I'm trying to use this branch to compile an app I have, but I'm still getting an error:

In lib/jennifer/src/jennifer/query_builder/nested_relation_tree.cr:31:29

 31 | models = bucket.map(&.[1].model_class)
                          ^
Error: type must be NoReturn, not PromptChain.class

I get this exact error every time I try to define a belongs_to or has_many relationship.

I'm on MacOS 17.7.2 on Crystal 1.15.0

@crimson-knight
Copy link
Contributor

Ok so, I can't reproduce this to another project yet. Apparently I just did something wild and it's breaking Jennifer some-how some-where 🤷‍♂️

@imdrasil
Copy link
Owner Author

imdrasil commented Feb 1, 2025

@crimson-knight could you pleases share with us how do you define those relations? Also does it mean when you comment them out everything is ok?

@crimson-knight
Copy link
Contributor

I was able to do some additional testing and it appears the crystal upgrade is unrelated. Commenting out the relationship macros does allow everything to compile. I'll have to do some additional testing to reproduce how I broke these macros 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants